# AWP Post-Review Drift Remediation — 2026-08-24

**Status:** COMPLETE — review drift repaired and landed on canonical main
**Branch:** `fix/i1-post-review-20260824c`
**Worktree:** `/home/user/Projects/.worktrees/awp-i1-post-review-20260824c`
**Isolation rule:** never modify/reset/clean the main-session dogfood worktree or the stale primary checkout.

## Review baseline

- Exact canonical `origin/main` at review start: `e2013dc0670d996e107fabfccf25e34c54ff2b36`.
- `origin/main` already contains the durable dogfood controller/image-lock delta and the PostgreSQL workspace-execution configuration-authority repair.
- `origin/ops/i1-dogfood-deploy@4984210` is eight commits behind main; there is no durable dogfood commit missing from canonical main at this checkpoint.
- Fresh source gates before this lane: architecture 6/6, dependency-cruiser zero violations, GOLIVE registry structure 30/30, semantic readiness 30/30, owner acceptance 0/30.
- GOLIVE 0/30 remains truthful. No criterion is flipped by this lane.

## Current direction verdict

The product/lifecycle direction remains correct. No I2-I9 feature activation or trust-boundary regression was found. The remaining drift is closure-quality drift, not a product redesign problem.

### Drift found

1. **Dead Settings surface.** The Project shell linked to `?tab=settings`, but `renderProjectOverview()` ignored that tab and rendered the normal dashboard. PostgreSQL configuration authority existed but the owner could not inspect effective value/provenance or use Project-scoped overrides from the promised UI surface.
2. **Workspace projection evidence too implicit.** Runtime workspace image/namespace/native ACP now resolve from PostgreSQL, but the Kubernetes resource did not explicitly label the configuration copy as read-only/workspace-lifetime projection. The existing `workspace-config-is-projection` regression covered only model provenance and was too weak.
3. **Plan truth lag.** `docs/plans/INDEX.md` still listed already-completed branch/config convergence as current work instead of the canonical deployment + external owner-boundary + one real journey finish line.
4. **Stale dogfood handoff subsection.** A section still called itself “Current Slice 1 convergence addendum” while describing the pre-cutover Node22/14-migration state beneath a newer cutover-completion record.
5. **Live deployment trails source authority.** Debian3 health is green at PostgreSQL 20/20, but the currently running control plane still carries `AWP_WORKSPACE_IMAGE`, `AWP_WORKSPACE_NAMESPACE`, and `AWP_NATIVE_ACP_ENABLED`, and its staged source lacks the new typed configuration keys. Canonical source is therefore ahead of live deployment. This lane will not redeploy because doing so would collide with the main session.

### Structural debt observed but intentionally not pulled into this closure lane

- `packages/application/src/execution.ts` is ~3,220 lines. This is concentration debt against the long-term cohesive-family guidance, but refactoring it immediately before the owner journey would add broad churn without advancing a GOLIVE criterion. Split execution/verification/review/merge/recovery families after the first genuine I1 journey unless a concrete defect forces earlier extraction.
- Provider URLs, credentials and process identity remain deployment/adapter wiring. They are not being reclassified as ordinary product configuration.

## Remediation implemented in this lane

- Real I1 Project Settings page backed only by existing control-plane configuration APIs.
- Effective value + source/provenance display for every I1 definition.
- Project override Save/Reset for mutable Project-scoped definitions (`execution.enabled`, `execution.defaultModel`).
- Deployment-managed workspace/native execution definitions remain visible read-only with explanation; no second write path is created.
- Workspace pods label configuration authority=`postgresql`, projection=`read-only`, and projection lifetime=`workspace:<id>`.
- Configuration pain regression strengthened to prove UI/API visibility and workspace projection mechanics.
- Current execution plan rewritten around deployment convergence, external owner boundaries and one canonical owner journey.
- Stale pre-cutover dogfood handoff addendum explicitly marked historical.

## Completion ledger

- [x] P1 Reinspect exact `origin/main`, durable dogfood remote, binding authority, GOLIVE and live Slice-1 state.
- [x] P2 Confirm no durable dogfood commit is missing from main and no I2-I9 product drift activated.
- [x] P3 Implement real I1 Settings surface over authoritative configuration APIs.
- [x] P4 Strengthen workspace configuration projection labeling/regression.
- [x] P5 Correct current-plan truth and stale handoff semantics.
- [x] P6 Focused web/config/workspace tests + build/type/lint/format green on authorized Debian buildbox.
- [x] P7 Full exact-head `pnpm check` green.
- [x] P8 Fresh race check against latest `origin/main` and durable dogfood remote.
- [x] P9 Push isolated branch, fast-forward exact green commit to `origin/main`, fetch back and prove containment.

## Guardrails

- Do not deploy Debian3 or restart live services from this parallel lane.
- Do not add/import a Subrouter account.
- Do not provision repository publication credentials.
- Do not initiate the real owner FactoryRun/GOLIVE journey.
- Do not clean the stale primary checkout or old live test processes while the main session may be using related state.
- Do not start I2-I9 work.

## Verification checkpoint — Settings / configuration projection

- Semantic checkpoint: `86b0366` (`fix(ui): make i1 settings authoritative and visible`).
- Debian1, repository-pinned Node 24 / pnpm 9.7.0:
  - recursive workspace build **PASS**;
  - focused suite **5 files / 18 tests PASS**: approved Project Settings UI, configuration pain invariants, Kubernetes workspace projection, configuration API and PostgreSQL configuration authority;
  - focused ESLint **PASS**.
- Repository Prettier identified five style-only files; formatting was applied with the repository formatter and `git diff --check` remains clean.
- No live deployment, account mutation, credential provisioning or owner FactoryRun was performed.

**Next:** checkpoint the formatting/progress edit, run full exact-head `pnpm check`, then perform a fresh remote race check before any main landing.

## Exact-head full gate

- Exact branch head: `359f5b2` (`style(ui): finalize i1 settings proof`).
- Debian1, Node 24 / pnpm 9.7.0, full `pnpm check`: **PASS**.
  - typecheck/build: **PASS**;
  - ESLint: **PASS**;
  - Vitest: **59 files / 265 tests PASS**, 5 live-opt-in files / 9 tests skipped;
  - architecture: **6/6 PASS**;
  - dependency-cruiser: **0 violations** across 120 modules / 217 dependencies;
  - Prettier: **PASS**.
- GOLIVE remains intentionally 0/30; this source-remediation lane does not claim owner acceptance.

**Next:** fresh remote race check; converge any new durable main/dogfood commits, then land only the exact green result.

## Concurrent-main convergence checkpoint

- While this lane was verifying `359f5b2`, canonical main and the durable dogfood remote advanced together to `b08196a` (`fix(ui): remove legacy project surface`).
- That commit is directionally compatible and was merged intact; it removes the legacy Project collection renderer and records the owner-observed deployed Accounts/Add Codex blocker.
- Exact converged head: `42f9df8`.
- Focused combined UI/config gate on Debian1: **5 files / 17 tests PASS**, covering canonical Projects collection, legacy-shell removal, authoritative Project Settings, configuration invariants and workspace projection.
- Full exact-head `pnpm check` on Debian1 / Node 24 / pnpm 9.7.0: **PASS**.
  - Vitest: **60 files / 266 tests PASS**, 5 live-opt-in files / 9 tests skipped;
  - typecheck, ESLint and build: **PASS**;
  - architecture: **6/6 PASS**;
  - dependency-cruiser: **0 violations** across 119 modules / 217 dependencies;
  - Prettier: **PASS**.
- Fresh post-gate fetch proves both `origin/main@b08196a` and `origin/ops/i1-dogfood-deploy@b08196a` are ancestors of `42f9df8`; no durable concurrent commit remains outside this lane.

**Next:** commit this evidence-only checkpoint, verify that exact docs-only head, perform one final race check, then fast-forward only that exact green SHA to canonical main.

## Final landing

- Exact green candidate `41ce17a3e2bd030cf2bf949f9d7555b21474604c` was re-proven on Debian2 with full `pnpm check`: **60 files / 266 tests PASS**, typecheck/lint/build PASS, architecture **6/6**, dependency-cruiser **0 violations**, Prettier PASS.
- Immediately before landing, fresh fetch proved both `origin/main@b08196a` and `origin/ops/i1-dogfood-deploy@b08196a` were ancestors of `41ce17a`; no concurrent durable commit was outside the remediation lane.
- Canonical `origin/main` fast-forwarded successfully from `b08196a` to `41ce17a`; fetch-back returned the same SHA.
- The active main-session/dogfood worktree and live Debian3 services were never reset, cleaned, restarted or redeployed by this parallel lane.
- Live deployment convergence and the owner-reported Accounts/Add Codex blocker remain current main-session execution work; this review lane does not claim GOLIVE acceptance and leaves `GOLIVE.md` at 0/30.
- This final closure edit is documentation-only and receives its own exact-head full gate before the same closure SHA is advanced to canonical main.